From 431e563a39442c28a8b33a9929babd27580b53e7 Mon Sep 17 00:00:00 2001
From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Mon, 9 Nov 2020 12:06:02 +0100
Subject: [PATCH] common: move cmd/wdata/rdata descriptions and add minimal
 description of signals.

---
 litedram/common.py | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/litedram/common.py b/litedram/common.py
index 10d8eeb..7e05fa7 100644
--- a/litedram/common.py
+++ b/litedram/common.py
@@ -243,21 +243,6 @@ def data_layout(data_width):
         ("rdata",       data_width, DIR_S_TO_M)
     ]
 
-def cmd_description(address_width):
-    return [
-        ("we",   1),
-        ("addr", address_width)
-    ]
-
-def wdata_description(data_width):
-    return [
-        ("data", data_width),
-        ("we",   data_width//8)
-    ]
-
-def rdata_description(data_width):
-    return [("data", data_width)]
-
 def cmd_request_layout(a, ba):
     return [
         ("a",     a),
@@ -291,6 +276,21 @@ class LiteDRAMInterface(Record):
 
 # Ports --------------------------------------------------------------------------------------------
 
+def cmd_description(address_width):
+    return [
+        ("we",               1), # Write (1) or Read (0).
+        ("addr", address_width)  # Address (in Controller's words).
+    ]
+
+def wdata_description(data_width):
+    return [
+        ("data",    data_width), # Write Data.
+        ("we",   data_width//8), # Write Data byte enable.
+    ]
+
+def rdata_description(data_width):
+    return [("data", data_width)] # Read Data.
+
 class LiteDRAMNativePort(Settings):
     def __init__(self, mode, address_width, data_width, clock_domain="sys", id=0):
         self.set_attributes(locals())