From 6f0c1b6a91f058da202c745202df688bf95a6135 Mon Sep 17 00:00:00 2001 From: Leon Schuermann Date: Sun, 21 Nov 2021 19:28:26 +0100 Subject: [PATCH 1/2] test_xgmii_phy: remove vcd dump of XGMII test Removes a slightly inappropriately named VCD dump created by the XGMII tests which may or may not have been a result of some frustration during the test implementation. :) Fixes: 8da0423f640b99 ("Add XGMII PHY tests based on captured ...") Signed-off-by: Leon Schuermann --- test/test_xgmii_phy.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test/test_xgmii_phy.py b/test/test_xgmii_phy.py index c5f52f3..cf72997 100644 --- a/test/test_xgmii_phy.py +++ b/test/test_xgmii_phy.py @@ -546,7 +546,6 @@ class TestXGMIIPHY(unittest.TestCase): and not xgmii_tx_collector.collecting, ), ], - vcd_name="xgmii_fuuuuuck.vcd", ) self.assertTrue( From 4a0b6f736f99e96e66c79817fea821ceadf6fe5b Mon Sep 17 00:00:00 2001 From: Leon Schuermann Date: Sun, 21 Nov 2021 19:31:07 +0100 Subject: [PATCH 2/2] phy/xgmii: fix description of IFG insertion Fixes: ea0a65d3570470 ("phy/xgmii: handle IFG insertion ...") Signed-off-by: Leon Schuermann --- liteeth/phy/xgmii.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liteeth/phy/xgmii.py b/liteeth/phy/xgmii.py index 196bcc6..2878a3d 100644 --- a/liteeth/phy/xgmii.py +++ b/liteeth/phy/xgmii.py @@ -248,7 +248,7 @@ class LiteEthPHYXGMIITX(Module): # Branch A: we've transmitted at least the full 12 bytes # IFG. This means that we can unconditionally start transmission # on the first octet. In addition to that, we may have inserted - # some extra XGMII, thus we can reduce the deficit. + # some extra IFG, thus we can reduce the deficit. *unshifted_idle_transmit, If(current_dic - last_packet_rem < 0, NextValue(current_dic, 0),