From 20b0e98fe019d380fbadcba5e27da01689aa47a2 Mon Sep 17 00:00:00 2001
From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Tue, 5 Nov 2024 16:46:23 +0100
Subject: [PATCH] cpu/urv: Fix Instruction Bus conversion to Wishbone and only
 keep it now that working.

---
 litex/soc/cores/cpu/urv/core.py  | 48 +++++++++++---------------------
 litex/soc/integration/builder.py |  5 ----
 2 files changed, 17 insertions(+), 36 deletions(-)

diff --git a/litex/soc/cores/cpu/urv/core.py b/litex/soc/cores/cpu/urv/core.py
index 1270b678b..36b385a9b 100644
--- a/litex/soc/cores/cpu/urv/core.py
+++ b/litex/soc/cores/cpu/urv/core.py
@@ -119,39 +119,25 @@ class uRV(CPU):
 
         # uRV Instruction Bus.
         # --------------------
-        if True:
-            from litex.soc.integration.common import get_mem_data
-            self.rom      = Memory(32, depth=131072//4)
-            self.rom_port = self.rom.get_port()
-
-            self.sync += im_valid.eq(1),
-            self.comb += [
-                self.rom_port.adr.eq(im_addr[2:]),
-                im_data.eq(self.rom_port.dat_r),
-            ]
-        else:
-            # FIXME: Try to implement im_bus -> Wishbone correctly (if possible).
-            im_addr_d = Signal(32, reset=0xffffffff)
-            self.sync += im_addr_d.eq(im_addr)
-            self.i_fsm = i_fsm = FSM(reset_state="IDLE")
-            i_fsm.act("IDLE",
-                If(im_addr != im_addr_d,
-                    NextValue(im_valid, 0),
-                    NextState("READ")
-                )
+        self.i_fsm = i_fsm = FSM(reset_state="IDLE")
+        i_fsm.act("IDLE",
+            If(im_rd,
+                NextValue(im_valid, 0),
+                NextState("READ")
             )
-            i_fsm.act("READ",
-                ibus.stb.eq(1),
-                ibus.cyc.eq(1),
-                ibus.we.eq(0),
-                ibus.adr.eq(im_addr),
-                ibus.sel.eq(0b1111),
-                If(ibus.ack,
-                    NextValue(im_valid, 1),
-                    NextValue(im_data, ibus.dat_r),
-                    NextState("IDLE")
-                )
+        )
+        i_fsm.act("READ",
+            ibus.stb.eq(1),
+            ibus.cyc.eq(1),
+            ibus.we.eq(0),
+            ibus.adr.eq(im_addr),
+            ibus.sel.eq(0b1111),
+            If(ibus.ack,
+                NextValue(im_valid, 1),
+                NextValue(im_data,  ibus.dat_r),
+                NextState("IDLE")
             )
+        )
 
         # uRV Data Bus.
         # -------------
diff --git a/litex/soc/integration/builder.py b/litex/soc/integration/builder.py
index a436ba52d..027862e8f 100644
--- a/litex/soc/integration/builder.py
+++ b/litex/soc/integration/builder.py
@@ -339,11 +339,6 @@ class Builder:
         # Initialize SoC with with BIOS data.
         self.soc.init_rom(name="rom", contents=bios_data)
 
-        # FIXME: Remove uRV ROM Init Workaround.
-        from litex.soc.cores.cpu.urv import uRV
-        if isinstance(self.soc.cpu, uRV):
-            self.soc.cpu.rom.init = bios_data
-
     def build(self, **kwargs):
         # Pass Output Directory to Platform.
         self.soc.platform.output_dir = self.output_dir