From 6b3a5412416e89869073dbc32540e6f2282c70fc Mon Sep 17 00:00:00 2001
From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Thu, 21 Apr 2022 18:15:05 +0200
Subject: [PATCH] xilinx/vivado: Differentiate IOs and internal nets when
 applying timing constraints.

Use get_nets on internal nets, get_ports on IOs.
---
 litex/build/xilinx/vivado.py | 22 ++++++++++++++--------
 litex/gen/fhdl/verilog.py    |  1 +
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/litex/build/xilinx/vivado.py b/litex/build/xilinx/vivado.py
index f23721764..936c407c9 100644
--- a/litex/build/xilinx/vivado.py
+++ b/litex/build/xilinx/vivado.py
@@ -284,18 +284,22 @@ class XilinxVivadoToolchain:
 
     def _build_clock_constraints(self, platform):
         platform.add_platform_command(_xdc_separator("Clock constraints"))
+        def get_clk_type(clk):
+            return {
+                False :  "nets",
+                True  : "ports",
+            }[hasattr(clk, "port")]
         for clk, period in sorted(self.clocks.items(), key=lambda x: x[0].duid):
             platform.add_platform_command(
                 "create_clock -name {clk} -period " + str(period) +
-                " [get_nets {clk}]", clk=clk)
-        for from_, to in sorted(self.false_paths,
-                                key=lambda x: (x[0].duid, x[1].duid)):
+                " [get_" + get_clk_type(clk) + " {clk}]", clk=clk)
+        for _from, _to in sorted(self.false_paths, key=lambda x: (x[0].duid, x[1].duid)):
             platform.add_platform_command(
                 "set_clock_groups "
-                "-group [get_clocks -include_generated_clocks -of [get_nets {from_}]] "
-                "-group [get_clocks -include_generated_clocks -of [get_nets {to}]] "
+                "-group [get_clocks -include_generated_clocks -of [get_" + get_clk_type(_from) + " {_from}]] "
+                "-group [get_clocks -include_generated_clocks -of [get_" + get_clk_type(_to)   + " {_to}]] "
                 "-asynchronous",
-                from_=from_, to=to)
+                _from=_from, _to=_to)
         # Make sure add_*_constraint cannot be used again
         del self.clocks
         del self.false_paths
@@ -341,12 +345,14 @@ class XilinxVivadoToolchain:
             fragment = fragment.get_fragment()
         platform.finalize(fragment)
 
+        # Generate verilog
+        v_output = platform.get_verilog(fragment, name=build_name, **kwargs)
+
         # Generate timing constraints
         self._build_clock_constraints(platform)
         self._build_false_path_constraints(platform)
 
-        # Generate verilog
-        v_output = platform.get_verilog(fragment, name=build_name, **kwargs)
+        # Add verilog to project.
         named_sc, named_pc = platform.resolve_signals(v_output.ns)
         v_file = build_name + ".v"
         v_output.write(v_file)
diff --git a/litex/gen/fhdl/verilog.py b/litex/gen/fhdl/verilog.py
index 842ed764e..84282a53c 100644
--- a/litex/gen/fhdl/verilog.py
+++ b/litex/gen/fhdl/verilog.py
@@ -391,6 +391,7 @@ def _print_module(f, ios, name, ns, attr_translate):
             r += "\t" + attr
         sig.type = "wire"
         sig.name = ns.get_name(sig)
+        sig.port = True
         if sig in inouts:
             sig.direction = "inout"
             r += "\tinout  wire " + _print_signal(ns, sig)