summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Peter Hurley 2010-04-16 14:15:40 -0400
committerGravatar Stefan Richter 2010-04-17 10:36:00 +0200
commitb15039ceb814ee4c685deec554f342480391b775 (patch)
tree923f61f6d4180985efd82a90f80542df5e31ba15
parentFix documentation of return values of raw1394_start_ family of functions (diff)
Fix for overlooked device HUP with 'firewire' stack
When EPOLLHUP event is received in fw_loop_iterate(), it is or'd with EPOLLERR. The EPOLLHUP event was then overlooked in handle_device_event() with unpredictable-but-generally bad results. This problem has been rediscovered several times. http://thread.gmane.org/gmane.linux.kernel.firewire.devel/13330 http://thread.gmane.org/gmane.linux.kernel.firewire.devel/13779 Reported-by: B.J. Buchalter <bj@mhlabs.com> Reported-by: Michael Thireos <mthireos@vanteon.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to '')
-rw-r--r--src/fw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/fw.c b/src/fw.c
index 7277253..d525ac9 100644
--- a/src/fw.c
+++ b/src/fw.c
@@ -262,7 +262,7 @@ handle_device_event(raw1394handle_t handle,
int i;
i = device - fwhandle->devices;
- if (events == EPOLLHUP)
+ if (events & EPOLLHUP)
return handle_lost_device(fwhandle, i);
len = read(fwhandle->devices[i].fd,
6b3aaaa2d8f36b3935?s=13&d=retro' width='13' height='13' alt='Gravatar' /> weihs 1-2/+6 2003-10-07Patch from Alexander Neundorf to add proto for raw1394_iso_recv_flush()Gravatar bencollins 1-0/+3 2003-09-26Update for new version, 0.10.1.Gravatar bencollins 2-2/+3 2003-09-26Fixup async_stream to use same local req variable for reentrancy.Gravatar bencollins 1-10/+10 2003-09-26Fix postinst so device node gets created.Gravatar bencollins 2-4/+6 2003-09-11Async stream support from Jim Radford.Gravatar bencollins 3-0/+42 2003-07-22Increase so maj/age so account for new recv-flush call.Gravatar bencollins 1-2/+2 2003-07-22Patch from Stephen Tiedemann to allow reentrancy in raw1394's usage ofGravatar bencollins 7-200/+199 2003-07-17Patch from Dan Maas to add raw1394_iso_recv_flush() call to API, using theGravatar bencollins 2-3/+25 2003-07-17pkg-config support from Kristian Hogsberg.Gravatar bencollins 3-1/+15 2003-07-17Remove trailing whitespace, which automake chokes on.Gravatar bencollins 1-1/+1 2003-07-13Fixed section for -dev package.Gravatar bencollins 1-1/+1 2003-07-13Re-add the pdf buildGravatar bencollins 1-0/+1 2003-07-13Update Debian files.Gravatar bencollins 4-25/+73 2003-07-13Ok, the Debian package was way out of sync with upstreamGravatar bencollins 1-1/+1 2003-07-13Ooops...libtool works a bit different than I thought, but atleast it worksGravatar bencollins 2-6/+1 2003-07-13Generate and install the pdf in the Debian package.Gravatar bencollins 3-3/+4 2003-07-13Don't run configure at the end of autogen.sh. Also, remove autom4te.cache.Gravatar bencollins 1-1/+1 2003-07-13Update Debian maintainerGravatar bencollins 1-1/+2 2003-07-13Update Debian changelog.Gravatar bencollins 1-0/+8 2003-07-13File doesn't really seem needed. The NEWS file gives a good overview, andGravatar bencollins 1-4/+0 2003-07-13Fix compiler warnings.Gravatar bencollins 4-12/+22 2003-07-13Updates from 0.10.0 release.Gravatar bencollins 4-5/+14 2003-04-23add libtoolize to bootstrapGravatar ddennedy 1-1/+10 2003-04-21added Dan Maas' rawiso docsGravatar ddennedy 1-32/+295 2003-04-07new_handle_on_port() error path fix from Jim RadfordGravatar dmaas 1-1/+3 2003-03-26add raw1394_new_handle_on_port() convenience functionGravatar dmaas 2-1/+41 2003-02-22Updates for new rawiso ioctl interface.Gravatar bencollins 3-37/+125 2003-01-15add iso_xmit_sync() and iso_xmit_write(); clean up iso handling a bitGravatar dmaas 5-39/+161 2003-01-15implement tag matching for rawiso receptionGravatar dmaas 3-4/+12 2003-01-06back out previous commit - don't drop the legacy API just yetGravatar dmaas 6-173/+130 2003-01-05emulate legacy ISO reception API on top of new rawiso APIGravatar dmaas 7-131/+174 2002-12-24update iso API for multi-channel reception and new packet buffer layoutGravatar dmaas 4-123/+236 2002-12-20oops, irq_interval needs to be signedGravatar anonymous 1-1/+1 2002-12-20dmaas - renamed exported arm definitions into the raw1394_ namespace; brought...Gravatar anonymous 3-124/+48 2002-12-16rawiso updates:Gravatar dmaas 3-18/+25 2002-11-18fix cplusplus extern C blockGravatar ddennedy 1-4/+4 2002-11-18merged rawiso branchGravatar ddennedy 7-6/+488