Tweak raw1394_add_config_rom_descriptor() API, add documentation and test case

To conform with 'size' arguments of other libraw1394 calls, change the one in
raw1394_add_config_rom_descriptor() from quadlets to bytes.  This breaks runtime
compatibility with potential clients that were written against B.J.'s original
patch, hence reorder arguments just to break compatibility also at compile time.

Change errno to ENOSYS (function not implemented) when called while running on
top of raw1394.

Allow &token to be NULL for convenience of clients which don't require
raw1394_remove_config_rom_descriptor().

Add exhaustive documentation.  Much of it is copied from the documentation of
the underlying ioctl.

Add example code which doubles as unit test in testlibraw.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

1 files changed, 4 insertions, 7 deletions

diff --git a/src/fw.h b/src/fw.h
index e64b2f3..cb1df01 100644
--- a/src/fw.h
+++ b/src/fw.h
@@ -202,13 +202,10 @@ int fw_start_fcp_listen(fw_handle_t handle);
 int fw_stop_fcp_listen(fw_handle_t handle);
 int fw_update_config_rom(fw_handle_t handle, const quadlet_t *new_rom,
 		   size_t size, unsigned char rom_version);
-int fw_add_config_rom_descriptor(fw_handle_t handle,
-	const quadlet_t	immediate_key,
-	const quadlet_t	key,
-	const quadlet_t *new_rom_directory,
-	size_t size,
-	__u32 *out_token);
-int fw_remove_config_rom_descriptor(fw_handle_t handle, __u32 token);
+int fw_add_config_rom_descriptor(fw_handle_t handle, u_int32_t *token,
+		   quadlet_t immediate_key, quadlet_t key,
+		   const quadlet_t *data, size_t size);
+int fw_remove_config_rom_descriptor(fw_handle_t handle, u_int32_t token);
 int fw_get_config_rom(fw_handle_t handle, quadlet_t *buffer,
 		   size_t buffersize, size_t *rom_size,
 		   unsigned char *rom_version);