summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Arvydas Silanskas 2021-11-11 20:09:12 +0200
committerGravatar Arvydas Silanskas 2021-11-11 20:09:12 +0200
commitf1b1e37b57ff1ecf1e7dd18dbb9204c402edf3c2 (patch)
treed9c2e182d0bdbe1790afdf693f15b4adf23720a6
parentMerge remote-tracking branch 'arvyy/master' (diff)
remove min-key, max-key, plist; add dependencies list to html
-rw-r--r--srfi-225-test.scm46
-rw-r--r--srfi-225.html135
-rw-r--r--srfi/225.sld2
-rw-r--r--srfi/default-impl.scm23
-rw-r--r--srfi/externals.scm2
-rw-r--r--srfi/indexes.scm2
-rw-r--r--srfi/plist-impl.scm111
7 files changed, 129 insertions, 192 deletions
diff --git a/srfi-225-test.scm b/srfi-225-test.scm
index 9de1e7b..31f862d 100644
--- a/srfi-225-test.scm
+++ b/srfi-225-test.scm
@@ -135,34 +135,6 @@
(test-equal (dict-ref/default dtd (alist->dict '((a . b))) 'a 'c) 'b)
(test-equal (dict-ref/default dtd (alist->dict '((a* . b))) 'a 'c) 'c))
- (test-group
- "dict-min-key"
- (define dict (alist->dict '((2 . a) (1 . b) (3 . c))))
- (call/cc (lambda (cont)
- (with-exception-handler
- (lambda (err)
- (unless (let* ((cmp (dict-comparator dtd (alist->dict '())))
- (ordering (and cmp (comparator-ordering-predicate cmp))))
- ordering)
- (cont #t)))
- (lambda ()
- (define key (dict-min-key dtd dict))
- (test-equal 1 key))))))
-
- (test-group
- "dict-max-key"
- (define dict (alist->dict '((2 . a) (3 . b) (1 . c))))
- (call/cc (lambda (cont)
- (with-exception-handler
- (lambda (err)
- (unless (let* ((cmp (dict-comparator dtd (alist->dict '())))
- (ordering (and cmp (comparator-ordering-predicate cmp))))
- ordering)
- (cont #t)))
- (lambda ()
- (define key (dict-max-key dtd dict))
- (test-equal 3 key))))))
-
(when mutable?
(test-skip 1))
(test-group
@@ -886,8 +858,7 @@
minimal-alist-dtd
alist-copy
#f
- #f
- ))
+ #f))
(test-group
"alist"
@@ -903,21 +874,6 @@
"alist dict-comparator"
(test-assert (not (dict-comparator alist-equal-dtd '())))))
-(test-group
- "plist"
- (do-test
- plist-dtd
- (lambda (alist)
- (apply append
- (map (lambda (pair)
- (list (car pair) (cdr pair)))
- alist)))
- #f
- #f)
- (test-group
- "plist dict-comparator"
- (test-assert (not (dict-comparator plist-dtd '())))))
-
(cond-expand
((and (library (srfi 69))
(not gauche)) ;; gauche has bug with comparator retrieval from srfi 69 table
diff --git a/srfi-225.html b/srfi-225.html
index 7c6584c..75fe5e9 100644
--- a/srfi-225.html
+++ b/srfi-225.html
@@ -334,7 +334,7 @@ the proc-id variable for <code>dict-map-id</code> and <code>dict-map!</code> is
<p>Note that it is not an error to omit any of these, but some dictionary procedures may be unavailable.</p>
<p>There are additional proc-id variables that may be provided with corresponding procedures in order to increase efficiency. For example, it is not necessary to provide a <code>dict-ref</code> procedure, because the default version is built on top of <code>dict-alter</code> or <code>dict-alter!</code>. But if the underlying dictionary provides its own <code>-ref</code> procedure, it may be more efficient to specify it to <code>make-dtd</code> using <code>dict-ref-id</code>. Here is the list of additional proc-id variables:</p>
<ul>
-<li><code>dict->alist-id</code></li>
+<li><code>dict-&gt;alist-id</code></li>
<li><code>dict-adjoin-accumulator-id</code></li>
<li><code>dict-adjoin-id</code></li>
<li><code>dict-any-id</code></li>
@@ -354,14 +354,12 @@ the proc-id variable for <code>dict-map-id</code> and <code>dict-map!</code> is
<li><code>dict-for-each-in-closed-open-interval-id</code></li>
<li><code>dict-for-each-in-open-closed-interval-id</code></li>
<li><code>dict-for-each-in-open-interval-id</code></li>
-<li><code>dict-for-each>-id</code></li>
-<li><code>dict-for-each>=-id</code></li>
+<li><code>dict-for-each&gt;-id</code></li>
+<li><code>dict-for-each&gt;=-id</code></li>
<li><code>dict-intern-id</code></li>
<li><code>dict-keys-id</code></li>
-<li><code>dict-map->list-id</code></li>
+<li><code>dict-map-&gt;list-id</code></li>
<li><code>dict-map-id</code></li>
-<li><code>dict-max-key-id</code></li>
-<li><code>dict-min-key-id</code></li>
<li><code>dict-pop-id</code></li>
<li><code>dict-ref-id</code></li>
<li><code>dict-ref/default-id</code></li>
@@ -407,7 +405,130 @@ and <code>equal?</code> respectively.</p>
<p>The sample implementation is found in the GitHub repository.</p>
<p>The following list of dependencies is designed to ease defining
new dictionary types that may not have complete dictionary APIs:</p>
-<b>FIXME</b>
+
+<dl>
+ <dt>dict-empty?</dt>
+ <dd>dict-size</dd>
+
+ <dt>dict=?</dt>
+ <dd>dict-ref</dd>
+ <dd>dict-keys</dd>
+ <dd>dict-size</dd>
+
+ <dt>dict-contains?</dt>
+ <dd>dict-ref</dd>
+
+ <dt>dict-ref</dt>
+ <dd>dict-mutable?</dd>
+ <dd>dict-alter or dict-alter!</dd>
+
+ <dt>dict-ref/default</dt>
+ <dd>dict-ref</dd>
+
+ <dt>dict-set</dt>
+ <dd>dict-alter</dd>
+
+ <dt>dict-adjoin</dt>
+ <dd>dict-alter</dd>
+
+ <dt>dict-delete</dt>
+ <dd>dict-delete-all</dt>
+
+ <dt>dict-delete-all</dt>
+ <dd>dict-alter</dd>
+
+ <dt>dict-replace</dt>
+ <dd>dict-alter</dd>
+
+ <dt>dict-intern</dt>
+ <dd>dict-alter</dt>
+
+ <dt>dict-update</dt>
+ <dd>dict-alter</dt>
+
+ <dt>dict-update/default</dt>
+ <dd>dict-update</dd>
+
+ <dt>dict-pop</dt>
+ <dd>dict-for-each</dd>
+ <dd>dict-delete-all</dd>
+ <dd>dict-empty?</dd>
+
+ <dt>dict-map</dt>
+ <dd>dict-keys</dd>
+ <dd>dict-ref</dd>
+ <dd>dict-replace</dd>
+
+ <dt>dict-filter</dt>
+ <dd>dict-keys</dd>
+ <dd>dict-ref</dd>
+ <dd>dict-delete-all</dd>
+
+ <dt>dict-remove</dt>
+ <dd>dict-filter</dd>
+
+ <dt>dict-count</dt>
+ <dd>dict-fold</dt>
+
+ <dt>dict-any</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-every</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-keys</dt>
+ <dd>dict-fold</dd>
+
+ <dt>dict-values</dt>
+ <dd>dict-fold</dd>
+
+ <dt>dict-entries</dt>
+ <dd>dict-fold</dd>
+
+ <dt>dict-fold</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-map-&gt;list</dt>
+ <dd>dict-fold</dd>
+
+ <dt>dict-&gt;alist</dt>
+ <dd>dict-map-&gt;list</dd>
+
+ <dt>dict-for-each&lt;</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each&lt;=</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each&gt;</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each&gt;=</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each-in-open-interval</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each-in-closed-interval</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each-in-open-closed-interval</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>dict-for-each-in-closed-open-interval</dt>
+ <dd>dict-for-each</dd>
+
+ <dt>make-dict-generator</dt>
+ <dd>dict-entries</dd>
+
+ <dt>dict-set-accumulator</dt>
+ <dd>dict-set</dd>
+
+ <dt>dict-adjoin-accumulator</dt>
+ <dd>dict-set</dd>
+
+</dl>
+
<h2 id="acknowledgements">Acknowledgements</h2>
<p>Thanks to the participants on the mailing list.</p>
diff --git a/srfi/225.sld b/srfi/225.sld
index 6e389a7..aee7c59 100644
--- a/srfi/225.sld
+++ b/srfi/225.sld
@@ -144,7 +144,6 @@
dict-adjoin-accumulator-id
;; basic DTDs
- plist-dtd
alist-eqv-dtd
alist-equal-dtd)
@@ -153,7 +152,6 @@
(include "externals.scm")
(include "default-impl.scm")
(include "alist-impl.scm")
- (include "plist-impl.scm")
;; library-dependent DTD exports
;; and implementations
diff --git a/srfi/default-impl.scm b/srfi/default-impl.scm
index d5bfdec..72c1f7f 100644
--- a/srfi/default-impl.scm
+++ b/srfi/default-impl.scm
@@ -74,27 +74,6 @@
(lambda () default)
(lambda (x) x)))
- (define (default-dict-find-key dtd dict cmp-proc)
- (define cmp (dict-comparator dtd dict))
- (define keys (dict-keys dtd dict))
- (when (not cmp)
- (raise (dictionary-error "dictionary doesn't have comparator")))
- (when (null? keys)
- (error "Cannot find min/max key in empty dictionary"))
- (let loop ((best (car keys))
- (keys (cdr keys)))
- (cond
- ((null? keys) best)
- ((cmp-proc cmp (car keys) best)
- (loop (car keys) (cdr keys)))
- (else (loop best (cdr keys))))))
-
- (define (default-dict-min-key dtd dict)
- (default-dict-find-key dtd dict <?))
-
- (define (default-dict-max-key dtd dict)
- (default-dict-find-key dtd dict >?))
-
;; private
(define (default-dict-set* dtd dictionary use-old? objs)
(let loop ((objs objs)
@@ -387,8 +366,6 @@
dict-mutable?-id default-dict-mutable?
dict-ref-id default-dict-ref
dict-ref/default-id default-dict-ref/default
- dict-min-key-id default-dict-min-key
- dict-max-key-id default-dict-max-key
dict-set-id default-dict-set
dict-adjoin-id default-dict-adjoin
dict-delete-id default-dict-delete
diff --git a/srfi/externals.scm b/srfi/externals.scm
index 5d77c86..519bccf 100644
--- a/srfi/externals.scm
+++ b/srfi/externals.scm
@@ -79,8 +79,6 @@
((dtd-ref-stx dtd dict-ref-id) dtd dict key failure success))))
(define/dict-proc dict-ref/default dict-ref/default-id)
-(define/dict-proc dict-min-key dict-min-key-id)
-(define/dict-proc dict-max-key dict-max-key-id)
(define/dict-proc-pair dict-set dict-set! dict-set-id)
(define/dict-proc-pair dict-adjoin dict-adjoin! dict-adjoin-id)
(define/dict-proc-pair dict-delete dict-delete! dict-delete-id)
diff --git a/srfi/indexes.scm b/srfi/indexes.scm
index f71a76e..a353de8 100644
--- a/srfi/indexes.scm
+++ b/srfi/indexes.scm
@@ -12,8 +12,6 @@
(define dict-mutable?-id (proc-id-inc))
(define dict-ref-id (proc-id-inc))
(define dict-ref/default-id (proc-id-inc))
-(define dict-min-key-id (proc-id-inc))
-(define dict-max-key-id (proc-id-inc))
(define dict-set-id (proc-id-inc))
(define dict-adjoin-id (proc-id-inc))
(define dict-delete-id (proc-id-inc))
diff --git a/srfi/plist-impl.scm b/srfi/plist-impl.scm
deleted file mode 100644
index d291870..0000000
--- a/srfi/plist-impl.scm
+++ /dev/null
@@ -1,111 +0,0 @@
-(define plist-dtd
- (let ()
-
- (define (plist? dtd l)
- (and (list? l)
- (or (null? l)
- (symbol? (car l)))))
-
- (define (plist-map dtd proc plist)
- (let loop ((pl plist)
- (new-pl/rev '()))
- (cond
- ((null? pl) (reverse new-pl/rev))
- ((null? (cdr pl)) (error "Malformed plist" plist))
- (else
- (let ((key (car pl))
- (value (cadr pl))
- (rest (cddr pl)))
- (loop rest
- (append (list (proc key value) key) new-pl/rev)))))))
-
- (define (plist-filter dtd pred plist)
- (let loop ((pl plist)
- (new-pl/rev '()))
- (cond
- ((null? pl) (reverse new-pl/rev))
- ((null? (cdr pl)) (error "Malformed plist" plist))
- (else
- (let ((key (car pl))
- (value (cadr pl))
- (rest (cddr pl)))
- (if (pred key value)
- (loop rest
- (append (list value key) new-pl/rev))
- (loop rest
- new-pl/rev)))))))
-
- (define (find-plist-entry key plist)
- (cond
- ((null? plist) #f)
- ((eq? key (car plist)) plist)
- (else (find-plist-entry key (cddr plist)))))
-
- (define (plist-delete key-to-delete plist)
- (let loop ((pl plist)
- (new-pl/rev '()))
- (cond
- ((null? pl) (reverse new-pl/rev))
- ((null? (cdr pl)) (error "Malformed plist"))
- (else (let ((key (car pl))
- (value (cadr pl))
- (rest (cddr pl)))
- (if (eq? key-to-delete key)
- (loop rest new-pl/rev)
- (loop rest (append (list value key) new-pl/rev))))))))
-
- (define (plist-alter dtd plist key failure success)
- (define (handle-success pair)
- (define old-key (car pair))
- (define old-value (cadr pair))
- (define (update new-key new-value)
- (cond
- ((and (eq? old-key
- new-key)
- (eq? old-value
- new-value))
- plist)
- (else
- (let ((new-list
- (append (list new-key new-value)
- (plist-delete old-key plist))))
- new-list))))
- (define (remove)
- (plist-delete old-key plist))
- (success old-key old-value update remove))
-
- (define (handle-failure)
- (define (insert value)
- (append (list key value) plist))
- (define (ignore)
- plist)
- (failure insert ignore))
- (cond
- ((find-plist-entry key plist) => handle-success)
- (else (handle-failure))))
-
- (define (plist-size dtd plist)
- (/ (length plist) 2))
-
- (define (plist-foreach dtd proc plist)
- (let loop ((pl plist))
- (if (null? pl) #t
- (begin
- (proc (car pl) (cadr pl))
- (loop (cddr pl))))))
-
- (define (plist-mutable? dtd plist)
- #f)
-
- (define (plist-comparator dtd plist)
- #f)
-
- (make-dtd
- dictionary?-id plist?
- dict-mutable?-id plist-mutable?
- dict-map-id plist-map
- dict-filter-id plist-filter
- dict-alter-id plist-alter
- dict-size-id plist-size
- dict-for-each-id plist-foreach
- dict-comparator-id plist-comparator)))