Hardware
/
litedram
mirror of https://github.com/enjoy-digital/litedram.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #352 from maribu/litedram/phy/lpddrX/commands.py/fix-invalid-escape-sequence 

litedram/phy/lpddr*: fix use of invalid escape sequence
This commit is contained in:
enjoy-digital 2024-03-25 19:06:08 +01:00 committed by GitHub
parent d6bf98790f 37e1f346e5
commit 7dacfaf684
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
litedram/phy/lpddr4/commands.py
View File

@ -199,18 +199,18 @@ class Command(Module):
assert len(self.dfi.address) >= 17, "At least 17 DFI addressbits needed for row address"
mr_address = self.dfi.bank if is_mrw else self.dfi.address
rules = {
"H": lambda: 1, # high
"L": lambda: 0, # low
"V": lambda: 0, # defined logic
"X": lambda: 0, # don't care
"BL": lambda: 0, # on-the-fly burst length, not using
"AP": lambda: self.dfi.address[10], # auto precharge
"AB": lambda: self.dfi.address[10], # all banks
"BA(\d+)": lambda i: self.dfi.bank[i],
"R(\d+)": lambda i: self.dfi.address[i], # row
"C(\d+)": lambda i: self.dfi.address[i], # column
"MA(\d+)": lambda i: mr_address[i], # mode register address
"OP(\d+)": lambda i: self.dfi.address[i], # mode register value, or operand for MPC
"H": lambda: 1, # high
"L": lambda: 0, # low
"V": lambda: 0, # defined logic
"X": lambda: 0, # don't care
"BL": lambda: 0, # on-the-fly burst length, not using
"AP": lambda: self.dfi.address[10], # auto precharge
"AB": lambda: self.dfi.address[10], # all banks
"BA(\\d+)": lambda i: self.dfi.bank[i],
"R(\\d+)": lambda i: self.dfi.address[i], # row
"C(\\d+)": lambda i: self.dfi.address[i], # column
"MA(\\d+)": lambda i: mr_address[i], # mode register address
"OP(\\d+)": lambda i: self.dfi.address[i], # mode register value, or operand for MPC
}
for pattern, value in rules.items():
m = re.match(pattern, bit)

40
litedram/phy/lpddr5/commands.py
View File

@ -275,27 +275,27 @@ class Command(Module):
op = mpc_op if is_mpc else self.dfi.address
rules = {
"H": lambda: 1, # high
"L": lambda: 0, # low
"V": lambda: 0, # defined logic
"X": lambda: 0, # don't care
"AB": lambda: self.dfi.address[10], # all banks
"AP": lambda: self.dfi.address[10], # auto precharge
"RFM": lambda: 0, # TODO: 1=RFM, 0=REF (Refresh Managemenent, only if r/o MR[27][0]=1, else always REF)
"SB(\d+)": lambda i: 0, # sub-bank selection related to RFM
"WS_WR": lambda: self.wck_sync == WCKSyncType.WR, # Write WCK2CK SYNC
"WS_RD": lambda: self.wck_sync == WCKSyncType.RD, # Read WCK2CK SYNC
"WS_FS": lambda: self.wck_sync == WCKSyncType.FS, # FAST SYNC
"DC(\d+)": lambda i: 0, # Data Copy, unimplemented
"WRX": lambda: 0, # Write X function, unimplemented
"WXSA": lambda: 0, # Write X function, unimplemented
"WXSB": lambda: 0, # Write X function, unimplemented
"BA(\d+)": lambda i: self.dfi.bank[i], # only BA0-2 is used, in BG/B16 modes we always refresh banks (x, x+8)
"R(\d+)": lambda i: self.dfi.address[i], # row
"H": lambda: 1, # high
"L": lambda: 0, # low
"V": lambda: 0, # defined logic
"X": lambda: 0, # don't care
"AB": lambda: self.dfi.address[10], # all banks
"AP": lambda: self.dfi.address[10], # auto precharge
"RFM": lambda: 0, # TODO: 1=RFM, 0=REF (Refresh Managemenent, only if r/o MR[27][0]=1, else always REF)
"SB(\\d+)": lambda i: 0, # sub-bank selection related to RFM
"WS_WR": lambda: self.wck_sync == WCKSyncType.WR, # Write WCK2CK SYNC
"WS_RD": lambda: self.wck_sync == WCKSyncType.RD, # Read WCK2CK SYNC
"WS_FS": lambda: self.wck_sync == WCKSyncType.FS, # FAST SYNC
"DC(\\d+)": lambda i: 0, # Data Copy, unimplemented
"WRX": lambda: 0, # Write X function, unimplemented
"WXSA": lambda: 0, # Write X function, unimplemented
"WXSB": lambda: 0, # Write X function, unimplemented
"BA(\\d+)": lambda i: self.dfi.bank[i], # only BA0-2 is used, in BG/B16 modes we always refresh banks (x, x+8)
"R(\\d+)": lambda i: self.dfi.address[i], # row
# LPDDR5 specs split the regular column address into C[5:0] "column address" and B[3:0] "burst address"
"C(\d+)": lambda i: self.dfi.address[i + 4],
"MA(\d+)": lambda i: mr_address[i], # mode register address
"OP(\d+)": lambda i: op[i], # mode register value, or operand for MPC
"C(\\d+)": lambda i: self.dfi.address[i + 4],
"MA(\\d+)": lambda i: mr_address[i], # mode register address
"OP(\\d+)": lambda i: op[i], # mode register value, or operand for MPC
}
for pattern, value in rules.items():