Merge pull request #230 from antmicro/jboc/test-init-diff

test: improve error messages when comparing files in test_init.py
This commit is contained in:
enjoy-digital 2021-01-30 21:47:19 +01:00 committed by GitHub
commit 9d80829e47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 14 deletions

View File

@ -5,19 +5,20 @@
# SPDX-License-Identifier: BSD-2-Clause # SPDX-License-Identifier: BSD-2-Clause
import os import os
import filecmp import difflib
import unittest import unittest
from litex.build.tools import write_to_file
from litedram.init import get_sdram_phy_c_header, get_sdram_phy_py_header from litedram.init import get_sdram_phy_c_header, get_sdram_phy_py_header
def compare_with_reference(content, filename): def compare_with_reference(test_case, content, filename):
write_to_file(filename, content) ref_filename = os.path.join("test", "reference", filename)
r = filecmp.cmp(filename, os.path.join("test", "reference", filename)) with open(ref_filename, "r") as f:
os.remove(filename) reference = f.read().split("\n")
return r content = content.split("\n")
diff = list(difflib.unified_diff(content, reference, fromfile=filename, tofile=ref_filename))
msg = "Unified diff:\n" + "\n".join(diff)
test_case.assertEqual(len(diff), 0, msg=msg)
class TestInit(unittest.TestCase): class TestInit(unittest.TestCase):
@ -26,21 +27,21 @@ class TestInit(unittest.TestCase):
soc = BaseSoC() soc = BaseSoC()
c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
self.assertEqual(compare_with_reference(c_header, "sdr_init.h"), True) compare_with_reference(self, c_header, "sdr_init.h")
self.assertEqual(compare_with_reference(py_header, "sdr_init.py"), True) compare_with_reference(self, py_header, "sdr_init.py")
def test_ddr3(self): def test_ddr3(self):
from litex_boards.targets.kc705 import BaseSoC from litex_boards.targets.kc705 import BaseSoC
soc = BaseSoC() soc = BaseSoC()
c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
self.assertEqual(compare_with_reference(c_header, "ddr3_init.h"), True) compare_with_reference(self, c_header, "ddr3_init.h")
self.assertEqual(compare_with_reference(py_header, "ddr3_init.py"), True) compare_with_reference(self, py_header, "ddr3_init.py")
def test_ddr4(self): def test_ddr4(self):
from litex_boards.targets.kcu105 import BaseSoC from litex_boards.targets.kcu105 import BaseSoC
soc = BaseSoC(max_sdram_size=0x4000000) soc = BaseSoC(max_sdram_size=0x4000000)
c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) c_header = get_sdram_phy_c_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing) py_header = get_sdram_phy_py_header(soc.sdram.controller.settings.phy, soc.sdram.controller.settings.timing)
self.assertEqual(compare_with_reference(c_header, "ddr4_init.h"), True) compare_with_reference(self, c_header, "ddr4_init.h")
self.assertEqual(compare_with_reference(py_header, "ddr4_init.py"), True) compare_with_reference(self, py_header, "ddr4_init.py")