Hardware
/
liteeth
mirror of https://github.com/enjoy-digital/liteeth.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

phy/rmii: Add with_refclk_ddr_ouptut parameter and minor cosmetic cleanups. 

Setting with_refclk_ddr_ouptut to False can allow use of RMII PHY on platforms
not supporting DDROutput.
This commit is contained in:
Florent Kermarrec 2023-05-24 19:18:53 +02:00
parent bbed8f1c95
commit a57178ac26
1 changed files with 32 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
liteeth/phy/rmii.py
View File

@ -1,7 +1,7 @@
# #
# This file is part of LiteEth. # This file is part of LiteEth.
# #
# Copyright (c) 2015-2018 Florent Kermarrec <florent@enjoy-digital.fr> # Copyright (c) 2015-2023 Florent Kermarrec <florent@enjoy-digital.fr>
# SPDX-License-Identifier: BSD-2-Clause # SPDX-License-Identifier: BSD-2-Clause
from migen import * from migen import *
@ -25,16 +25,17 @@ class LiteEthPHYRMIITX(Module):
# # # # # #
converter = stream.StrideConverter(converter_description(8), self.submodules.converter = converter = stream.StrideConverter(
converter_description(2)) description_from = converter_description(8),
self.submodules += converter description_to = converter_description(2),
)
self.comb += [ self.comb += [
converter.sink.valid.eq(sink.valid), converter.sink.valid.eq(sink.valid),
converter.sink.data.eq(sink.data), converter.sink.data.eq(sink.data),
sink.ready.eq(converter.sink.ready), sink.ready.eq(converter.sink.ready),
converter.source.ready.eq(1) converter.source.ready.eq(1)
] ]
pads.tx_en.reset_less = True pads.tx_en.reset_less = True
pads.tx_data.reset_less = True pads.tx_data.reset_less = True
self.sync += [ self.sync += [
pads.tx_en.eq(converter.source.valid), pads.tx_en.eq(converter.source.valid),
@ -48,22 +49,24 @@ class LiteEthPHYRMIIRX(Module):
# # # # # #
converter = stream.StrideConverter(converter_description(2), converter = stream.StrideConverter(
converter_description(8)) description_from = converter_description(2),
description_to = converter_description(8),
)
converter = ResetInserter()(converter) converter = ResetInserter()(converter)
self.submodules += converter self.submodules.converter = converter
converter_sink_valid = Signal() converter_sink_valid = Signal()
converter_sink_data = Signal(2) converter_sink_data = Signal(2)
self.specials += [ self.specials += [
MultiReg(converter_sink_valid, converter.sink.valid, n=2), MultiReg(converter_sink_valid, converter.sink.valid, n=2),
MultiReg(converter_sink_data, converter.sink.data, n=2) MultiReg(converter_sink_data, converter.sink.data, n=2)
] ]
crs_dv = Signal() crs_dv = Signal()
crs_dv_d = Signal() crs_dv_d = Signal()
rx_data = Signal(2) rx_data = Signal(2)
self.sync += [ self.sync += [
crs_dv.eq(pads.crs_dv), crs_dv.eq(pads.crs_dv),
crs_dv_d.eq(crs_dv), crs_dv_d.eq(crs_dv),
@ -83,7 +86,7 @@ class LiteEthPHYRMIIRX(Module):
fsm.act("RECEIVE", fsm.act("RECEIVE",
converter_sink_valid.eq(1), converter_sink_valid.eq(1),
converter_sink_data.eq(rx_data), converter_sink_data.eq(rx_data),
# end of frame when 2 consecutives 0 on crs_dv # End of frame when 2 consecutives 0 on crs_dv.
If(~(crs_dv | crs_dv_d), If(~(crs_dv | crs_dv_d),
converter.sink.last.eq(1), converter.sink.last.eq(1),
NextState("IDLE") NextState("IDLE")
@ -93,7 +96,9 @@ class LiteEthPHYRMIIRX(Module):
class LiteEthPHYRMIICRG(Module, AutoCSR): class LiteEthPHYRMIICRG(Module, AutoCSR):
def __init__(self, clock_pads, pads, refclk_cd, with_hw_init_reset): def __init__(self, clock_pads, pads, refclk_cd,
with_hw_init_reset = True,
with_refclk_ddr_output = True):
self._reset = CSRStorage() self._reset = CSRStorage()
# # # # # #
@ -114,7 +119,10 @@ class LiteEthPHYRMIICRG(Module, AutoCSR):
self.comb += self.cd_eth_tx.clk.eq(ClockSignal(refclk_cd)) self.comb += self.cd_eth_tx.clk.eq(ClockSignal(refclk_cd))
# Drive clock_pads if provided. # Drive clock_pads if provided.
if clock_pads is not None: if clock_pads is not None:
self.specials += DDROutput(0, 1, clock_pads.ref_clk, ClockSignal("eth_tx")) if with_refclk_ddr_output:
self.specials += DDROutput(i1=0, i2=1, o=clock_pads.ref_clk, clk=ClockSignal("eth_tx"))
else:
self.comb += clock_pads.ref_clk.eq(~ClockSignal("eth_tx")) # CHEKCME: Keep Invert?
# Reset # Reset
self.reset = reset = Signal() self.reset = reset = Signal()
@ -135,10 +143,15 @@ class LiteEthPHYRMII(Module, AutoCSR):
dw = 8 dw = 8
tx_clk_freq = 50e6 tx_clk_freq = 50e6
rx_clk_freq = 50e6 rx_clk_freq = 50e6
def __init__(self, clock_pads, pads, refclk_cd="eth", with_hw_init_reset=True): def __init__(self, clock_pads, pads, refclk_cd="eth",
self.submodules.crg = LiteEthPHYRMIICRG(clock_pads, pads, refclk_cd, with_hw_init_reset) with_hw_init_reset = True,
self.submodules.tx = ClockDomainsRenamer("eth_tx")(LiteEthPHYRMIITX(pads)) with_refclk_ddr_output = True):
self.submodules.rx = ClockDomainsRenamer("eth_rx")(LiteEthPHYRMIIRX(pads)) self.submodules.crg = LiteEthPHYRMIICRG(clock_pads, pads, refclk_cd,
with_hw_init_reset = with_hw_init_reset,
with_refclk_ddr_output = with_refclk_ddr_output,
)
self.submodules.tx = ClockDomainsRenamer("eth_tx")(LiteEthPHYRMIITX(pads))
self.submodules.rx = ClockDomainsRenamer("eth_rx")(LiteEthPHYRMIIRX(pads))
self.sink, self.source = self.tx.sink, self.rx.source self.sink, self.source = self.tx.sink, self.rx.source
if hasattr(pads, "mdc"): if hasattr(pads, "mdc"):