Hardware/liteeth
1
0
Fork 0
mirror of https://github.com/enjoy-digital/liteeth.git synced 2025-01-03 03:43:37 -05:00
Code Issues Projects Releases Packages Wiki Activity

icmp.py: take icmp type field into account

Browse source 
* only send a ping reply to type 8 (ping request) packets
  * otherwise liteeth would send a ping reply to
    `destination unreachable` packets too, which is not wanted
This commit is contained in:
Michael Betz 2021-12-27 23:39:35 +01:00
parent a8d9c5ef6a
commit bc073a5d2c
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
liteeth/common.py
View file

@ -84,6 +84,8 @@ ipv4_header = Header(ipv4_header_fields, ipv4_header_length, swap_field_bytes=Tr
# ICMP Constants/Header ----------------------------------------------------------------------------
icmp_protocol = 0x01
icmp_type_ping_reply = 0
icmp_type_ping_request = 8
icmp_header_length = 8
icmp_header_fields = {
"msgtype": HeaderField(0, 0, 8),

4
liteeth/core/icmp.py
View file

@ -86,10 +86,12 @@ class LiteEthICMPRX(Module):
If(depacketizer.source.valid,
NextState("DROP"),
If(sink.protocol == icmp_protocol,
If(depacketizer.source.msgtype == icmp_type_ping_request,
NextState("RECEIVE")
)
)
)
)
self.comb += [
depacketizer.source.connect(source, keep={
"last",
@ -137,7 +139,7 @@ class LiteEthICMPEcho(Module):
self.comb += [
sink.connect(self.buffer.sink),
self.buffer.source.connect(source, omit={"checksum"}),
self.source.msgtype.eq(0x0),
self.source.msgtype.eq(icmp_type_ping_reply),
self.source.checksum.eq(self.buffer.source.checksum + 0x800 + (self.buffer.source.checksum >= 0xf800))
]