soc/add_pcie: Remove MSI workaround on Ultrascale(+) now that root cause is understood/fixed (thanks @smunaut).

This commit is contained in:
Florent Kermarrec 2023-07-21 14:50:38 +02:00
parent aae15737cd
commit 330d61d2bd
2 changed files with 2 additions and 9 deletions

View File

@ -11,6 +11,7 @@
- liteiclink/serwb : Fixed 7-Series initialization corner cases.
- liteeth/core/icmp : Fixed length check on LiteEthICMPEcho before passing data to buffer.
- LiteXModule/CSR : Fixed CSR collection order causing CSR clock domain to be changed.
- litepcie/US(P) : Fixed root cause of possible MSI deadlock.
[> Added
--------

View File

@ -2035,16 +2035,8 @@ class LiteXSoC(SoC):
if msi_type == "msi-x":
msi = LitePCIeMSIX(endpoint=self.pcie_endpoint, width=msi_width)
self.add_module(name=f"{name}_msi", module=msi)
# FIXME: On Ultrascale/Ultrascale+ limit rate of IRQs to 1MHz (to prevent issue with
# IRQs stalled).
if msi_type in ["msi", "msi-multi-vector"]:
if isinstance(phy, (USPCIEPHY, USPPCIEPHY)):
msi_timer = WaitTimer(int(self.sys_clk_freq/1e6))
self.add_module(name=f"{name}_msi_timer", module=msi_timer)
self.comb += msi_timer.wait.eq(~msi_timer.done)
self.comb += If(msi_timer.done, msi.source.connect(phy.msi))
else:
self.comb += msi.source.connect(phy.msi)
self.comb += msi.source.connect(phy.msi)
self.msis = {}
# DMAs.