soc_core: move CSR bridge to finalize (only generate it if there is a wishbone master), revert default parameter when cpu_type is None (we have systems with cpu_type=None but that are using these peripherals)

This commit is contained in:
Florent Kermarrec 2019-09-23 09:58:47 +02:00
parent dde6dd027b
commit a9acab99b3
1 changed files with 15 additions and 18 deletions

View File

@ -204,15 +204,8 @@ class SoCCore(Module):
if cpu_type == "None": if cpu_type == "None":
cpu_type = None cpu_type = None
self.soc_mem_map["csr"] = 0
l2_size = 0
integrated_rom_size = 0
integrated_sram_size = 0
with_uart = False
with_timer = False
with_ctrl = False
self.cpu_type = cpu_type self.cpu_type = cpu_type
self.cpu_variant = cpu.check_format_cpu_variant(cpu_variant) self.cpu_variant = cpu.check_format_cpu_variant(cpu_variant)
if integrated_rom_size: if integrated_rom_size:
@ -229,6 +222,7 @@ class SoCCore(Module):
assert csr_data_width in [8, 32, 64] assert csr_data_width in [8, 32, 64]
assert csr_alignment in [32, 64] assert csr_alignment in [32, 64]
assert 2**(csr_address_width + 2) <= 0x1000000
self.csr_data_width = csr_data_width self.csr_data_width = csr_data_width
self.csr_alignment = csr_alignment self.csr_alignment = csr_alignment
self.csr_address_width = csr_address_width self.csr_address_width = csr_address_width
@ -308,16 +302,6 @@ class SoCCore(Module):
self.submodules.main_ram = wishbone.SRAM(integrated_main_ram_size, init=integrated_main_ram_init) self.submodules.main_ram = wishbone.SRAM(integrated_main_ram_size, init=integrated_main_ram_init)
self.register_mem("main_ram", self.soc_mem_map["main_ram"], self.main_ram.bus, integrated_main_ram_size) self.register_mem("main_ram", self.soc_mem_map["main_ram"], self.main_ram.bus, integrated_main_ram_size)
# Add Wishbone to CSR bridge
self.config["CSR_DATA_WIDTH"] = csr_data_width
self.config["CSR_ALIGNMENT"] = csr_alignment
assert 2**(csr_address_width + 2) <= 0x1000000
if cpu_type is not None:
self.submodules.wishbone2csr = wishbone2csr.WB2CSR(
bus_csr=csr_bus.Interface(csr_data_width, csr_address_width))
self.add_csr_master(self.wishbone2csr.csr)
self.register_mem("csr", self.soc_mem_map["csr"], self.wishbone2csr.wishbone, 0x1000000)
# Add UART # Add UART
if with_uart: if with_uart:
if uart_stub: if uart_stub:
@ -518,6 +502,19 @@ class SoCCore(Module):
if mem not in registered_mems: if mem not in registered_mems:
raise FinalizeError("CPU needs \"{}\" to be registered with SoC.register_mem()".format(mem)) raise FinalizeError("CPU needs \"{}\" to be registered with SoC.register_mem()".format(mem))
# Add Wishbone to CSR bridge
self.finalized = False # FIXME
self.config["CSR_DATA_WIDTH"] = self.csr_data_width
self.config["CSR_ALIGNMENT"] = self.csr_alignment
if len(self._wb_masters):
self.submodules.wishbone2csr = wishbone2csr.WB2CSR(
bus_csr=csr_bus.Interface(
address_width=self.csr_address_width,
data_width=self.csr_address_width))
self.add_csr_master(self.wishbone2csr.csr)
self.register_mem("csr", self.soc_mem_map["csr"], self.wishbone2csr.wishbone, 0x1000000)
self.finalized = True # FIXME
# Add the Wishbone Masters/Slaves interconnect # Add the Wishbone Masters/Slaves interconnect
if len(self._wb_masters): if len(self._wb_masters):
self.submodules.wishbonecon = wishbone.InterconnectShared(self._wb_masters, self.submodules.wishbonecon = wishbone.InterconnectShared(self._wb_masters,