command: remove success/failed redundancy (keep failed)

This commit is contained in:
Florent Kermarrec 2015-01-22 00:23:11 +01:00
parent ff0c8e3d22
commit c9761be54f
4 changed files with 0 additions and 8 deletions

View File

@ -214,7 +214,6 @@ def command_rx_description(dw):
("read", 1), ("read", 1),
("identify", 1), ("identify", 1),
("last", 1), ("last", 1),
("success", 1),
("failed", 1), ("failed", 1),
("data", dw) ("data", dw)
] ]
@ -226,7 +225,6 @@ def command_rx_cmd_description(dw):
("read", 1), ("read", 1),
("identify", 1), ("identify", 1),
("last", 1), ("last", 1),
("success", 1),
("failed", 1) ("failed", 1)
] ]
return EndpointDescription(layout, packetized=False) return EndpointDescription(layout, packetized=False)

View File

@ -192,7 +192,6 @@ class LiteSATACommandRX(Module):
source.eop.eq(1), source.eop.eq(1),
source.write.eq(1), source.write.eq(1),
source.last.eq(1), source.last.eq(1),
source.success.eq(~transport.source.error & ~d2h_error),
source.failed.eq(transport.source.error | d2h_error), source.failed.eq(transport.source.error | d2h_error),
If(source.stb & source.ack, If(source.stb & source.ack,
NextState("IDLE") NextState("IDLE")
@ -232,7 +231,6 @@ class LiteSATACommandRX(Module):
source.eop.eq(transport.source.eop), source.eop.eq(transport.source.eop),
source.read.eq(~is_identify), source.read.eq(~is_identify),
source.identify.eq(is_identify), source.identify.eq(is_identify),
source.success.eq(~transport.source.error),
source.failed.eq(transport.source.error), source.failed.eq(transport.source.error),
source.last.eq(is_identify), source.last.eq(is_identify),
source.data.eq(transport.source.data), source.data.eq(transport.source.data),
@ -255,7 +253,6 @@ class LiteSATACommandRX(Module):
source.eop.eq(1), source.eop.eq(1),
source.read.eq(1), source.read.eq(1),
source.last.eq(1), source.last.eq(1),
source.success.eq(read_done & ~read_error & ~d2h_error),
source.failed.eq(~read_done | read_error | d2h_error), source.failed.eq(~read_done | read_error | d2h_error),
If(source.stb & source.ack, If(source.stb & source.ack,
NextState("IDLE") NextState("IDLE")

View File

@ -32,7 +32,6 @@ class CommandRXPacket(list):
self.done = False self.done = False
self.write = 0 self.write = 0
self.read = 0 self.read = 0
self.success = 0
self.failed = 0 self.failed = 0
class CommandLogger(PacketLogger): class CommandLogger(PacketLogger):
@ -45,7 +44,6 @@ class CommandLogger(PacketLogger):
self.packet = CommandRXPacket() self.packet = CommandRXPacket()
self.packet.write = selfp.sink.write self.packet.write = selfp.sink.write
self.packet.read = selfp.sink.read self.packet.read = selfp.sink.read
self.packet.sucess = selfp.sink.success
self.packet.failed = selfp.sink.failed self.packet.failed = selfp.sink.failed
self.packet.append(selfp.sink.data) self.packet.append(selfp.sink.data)
elif selfp.sink.stb: elif selfp.sink.stb:

View File

@ -187,7 +187,6 @@ class BISTSoCDevel(BISTSoC, AutoCSR):
self.sata.core.command.source.write, self.sata.core.command.source.write,
self.sata.core.command.source.read, self.sata.core.command.source.read,
self.sata.core.command.source.identify, self.sata.core.command.source.identify,
self.sata.core.command.source.success,
self.sata.core.command.source.failed, self.sata.core.command.source.failed,
self.sata.core.command.source.data, self.sata.core.command.source.data,